Fix dialyzer issues and add tests

Author: JohnDoneth

lib/upload/changeset.ex

@@ -24,8 +24,9 @@ defmodule Upload.Changeset do
   @type error :: binary | Ecto.Changeset.error()
   @type validation :: (any -> [error])
   @type size :: {number, :byte | :kilobyte | :megabyte | :gigabyte | :terabyte}
+  @type key_function :: (changeset -> String.t())
 
-  @type cast_opts :: [{:invalid_message, binary}]
+  @type cast_opts :: [{:invalid_message, binary} | {:key_function, key_function}]
   @type size_opts :: [{:less_than, size} | {:message, binary}]
   @type type_opts :: [{:allow, [binary]} | {:forbid, [binary]} | {:message, binary}]
 

lib/upload/multi.ex

@@ -268,7 +268,7 @@ defmodule Upload.Multi do
       when is_function(fun, 1) and is_function(transform_fn, 3) do
     repo = Upload.Config.repo()
 
-    Multi.run(multi, opts[:multi_name] || :create_variants, fn ctx ->
+    Multi.run(multi, opts[:multi_name] || :create_variants, fn _repo, ctx ->
       case fun.(ctx) do
         nil ->
           {:ok, nil}
@@ -322,7 +322,7 @@ defmodule Upload.Multi do
       when is_function(fun, 1) and is_function(transform_fn, 3) do
     repo = Upload.Config.repo()
 
-    Multi.run(multi, opts[:multi_name] || :create_variants, fn ctx ->
+    Multi.run(multi, opts[:multi_name] || :create_variants, fn _repo, ctx ->
       case fun.(ctx) do
         nil ->
           {:ok, nil}

test/upload/multi_test.exs

@@ -1,5 +1,6 @@
 defmodule Upload.MultiTest do
   use Upload.DataCase
+  use Upload.Testing
 
   alias Upload.Storage
   alias Upload.Test.Person
@@ -13,7 +14,7 @@ defmodule Upload.MultiTest do
   @upload %Plug.Upload{path: @path, filename: "image.jpg"}
 
   describe "handle_changes" do
-    test "can validate changes" do
+    test "will validate changes" do
       changeset = Person.changeset(%Person{}, %{avatar: "test/fixtures/test.txt"})
 
       {:error, _, changeset, _} =
@@ -31,6 +32,48 @@ defmodule Upload.MultiTest do
     end
   end
 
+  describe "create_variant" do
+    test "will create a variant" do
+      changeset = Person.changeset(%Person{}, %{avatar: @upload})
+
+      {:ok, _} =
+        Ecto.Multi.new()
+        |> Ecto.Multi.insert(:person, changeset)
+        |> Upload.Multi.handle_changes(:upload_avatar, :person, changeset, :avatar,
+          key_function: &key_function/1
+        )
+        |> Upload.Multi.create_variant(
+          fn ctx -> ctx.upload_avatar.avatar end,
+          :small,
+          &small_transform/3
+        )
+        |> Repo.transaction()
+
+      person = Repo.one(Person) |> Repo.preload(avatar: :variants)
+
+      variant = List.first(person.avatar.variants)
+
+      assert variant.variant == "small"
+    end
+
+    test "handles when there are no changes" do
+      changeset = Person.changeset(%Person{}, %{})
+
+      {:ok, _} =
+        Ecto.Multi.new()
+        |> Ecto.Multi.insert(:person, changeset)
+        |> Upload.Multi.handle_changes(:upload_avatar, :person, changeset, :avatar,
+          key_function: &key_function/1
+        )
+        |> Upload.Multi.create_variant(
+          fn ctx -> ctx.upload_avatar.avatar end,
+          :small,
+          &small_transform/3
+        )
+        |> Repo.transaction()
+    end
+  end
+
   test "upload/3" do
     assert {:ok, person} = insert_person(%{avatar: @upload})
     assert person.avatar_id