Skip to content

Commit 7c4bbc9

Browse files
committed
(maint) Remove gem update --system and pin rainbow
Travis fails with the combination of bundler 1.7.6 and rubygems 2.6, as they are not compatible: NoMethodError: undefined method `spec' for nil:NilClass This commit removes the `gem update --system` since we are no longer installing a particular version of bundler. The thinking is that Travis provides consistent versions of rubygems and bundler in all supported ruby versions that we support. This commit also pins rainbow, as newer versions are not compatible[1] with ruby 2.4 and bundler 1.14.0, leading to errors like: Gem::Ext::BuildError: ERROR: Failed to build gem native extension. [1] ku1ik/rainbow#48
1 parent 24102a1 commit 7c4bbc9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.travis.yml

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
language: ruby
22
sudo: false
3-
before_install:
4-
- gem update --system --no-doc
53
bundler_args: --without development extra
64
script:
75
- "bundle exec rake $CHECK"

Gemfile

+2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ group(:development, :test) do
5757
gem "json-schema", "2.1.1", :require => false, :platforms => [:ruby, :jruby]
5858

5959
gem "rubocop", "~> 0.39.0", :platforms => [:ruby]
60+
# pin rainbow gem as 2.2.1 requires rubygems 2.6.9+ and (donotwant)
61+
gem "rainbow", "< 2.2.1", :platforms => [:ruby]
6062

6163
gem 'rdoc', "~> 4.1", :platforms => [:ruby]
6264

0 commit comments

Comments
 (0)