Drag selected contents up and down #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/lib/components/modes/treemode/JSONNode.svelte # src/lib/components/modes/treemode/TreeMode.svelte # src/lib/utils/domUtils.js # src/lib/utils/domUtils.test.js
# Conflicts: # src/lib/components/modes/treemode/JSONNode.svelte
# Conflicts: # src/lib/components/modes/treemode/JSONNode.svelte # src/lib/components/modes/treemode/TreeMode.svelte
… map with heights
josdejong
added a commit
that referenced
this pull request
Mar 22, 2022
* feat: drag and drop experiment (WIP) * feat: drag selection up or down (WIP) * feat: handle dragging selection inside the parent Array/Object node (WIP) * chore: cleanup a console.log * fix: reckon with scrolling up/down when dragging contents * fix: dragging selection down in an object * fix: be able to drag over the last property of an object * fix: find next/previous path inside nested array * fix: dragging selection inside an array mostly working (WIP) * feat: show grab cursor on selected area * fix: use global mouse move listener whilst dragging * fix: paths in selection not always ordered * chore: refactor findSwapPath into findSwapPathUp and findSwapPathDown * fix: dragging a selection in an array over an expanded object up/down is not smooth * fix: array selection whilst dragging (WIP) * fix: not being able to drag starting on nested nodes * fix: drag event handers being called multiple times * fix: only refresh the dragging object when there is an actual change * fix: selection gone when draggin a single selected array item * chore: extract onMoveSelection into a separate function * chore: extract nested functions from onMoveSelection * chore: remove the need to pass value, state, selection, path to onMoveSelection * chore: remove redundant variable * chore: refactor onMoveSelection to use a list with items instead of a map with heights * docs: add a TODO with an idea for performance optimization * fix: should keep selection as is after dragging a single item to the bottom of an object * fix: disable dragging of partially invisible items * fix: disable dragging a selection across array sections, write unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.