ESM import bug

[mikiastilahun]

I am getting these errors when I try to use it in a svelte project with Webpack 5.

• ERROR in ./node_modules/.pnpm/svelte-jsoneditor@0.9.2/node_modules/svelte-jsoneditor/logic/history.js 1:0-45
  Module not found: Error: Can't resolve '../utils/debug' in svelte-jsoneditor/logic'
  Did you mean 'debug.js'?

• ERROR in ./node_modules/.pnpm/svelte-jsoneditor@0.9.2/node_modules/svelte-jsoneditor/plugins/value/components/utils/getValueClass.js 1:0-63
  Module not found: Error: Can't resolve '../../../../utils/typeUtils' in /svelte-jsoneditor/plugins/value/components/utils'
  Did you mean 'typeUtils.js'?

Any idea how to fix them?
Thanks in advance.

[josdejong]

Thanks, good point.

In the setup of svelte-jsoneditor this is no problem, since the dependencies are resolved using nodejs resolution.

Just wondering: does adding the missing .js extensions resolve the issues in your setup? It still does not make the library truely ESM, since there are nodejs dependencies involved which are not imported with an url but with the module name.

Your solution in #191 will solve the issue, but will not guard against future issues. I think we need something like an eslint rule which warns us against a missing .js extension. Is this something you can/want to look into?

Alternatively, it may be possible to configure the build tools (Typescript, Rollup, Babel) to make sure the generated files do have a proper .js extension.

[mikiastilahun]

Yes, the issue is resolved after adding the missing .js extensions. For now, I'm able to use my forked version, but you are absolutely right that we need to configure the build processes to ensure this won't happen in the future. I can look into it more and get back to you.

[josdejong]

For now, I'm able to use my forked version

Good to know you have a temporary workaround. We can indeed merge your PR as is, but need a long term solution too.

I can look into it more and get back to you.

That would be great, thanks!

[josdejong]

I've setup the import/extensions eslint plugin to check for .js file extensions for all imports.