Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readOnly option #130

Closed
wants to merge 1 commit into from
Closed

improve readOnly option #130

wants to merge 1 commit into from

Conversation

fonov
Copy link

@fonov fonov commented Aug 26, 2022

I notified that keyboard is appeared on mobile device even readOnly is set true when user tap on editor.

Set EditorView.editable -> false disable appeared keyboard on tap or select

@josdejong
Copy link
Owner

Thanks Fonov for the fix!

I think the function updateReadOnly should also be adapted.

Thinking about this: probably we should remove the EditorState.readOnly and instead just use EditorView.editable?

@josdejong
Copy link
Owner

@fonov what do you think?

@josdejong josdejong closed this in 1c669fa Sep 12, 2022
@josdejong
Copy link
Owner

I've tried out only using EditorView.editable, but then certain actions are still working, like Ctrl+V to paste something. So now I've defined both EditorView.editable and EditorState.readOnly.

@josdejong
Copy link
Owner

fixed now in v0.7.4, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants