Skip to content

Commit 3d5cef3

Browse files
committed
pipes: Use 'go-cmp' in unit tests.
1 parent 3229613 commit 3d5cef3

4 files changed

+26
-12
lines changed

internal/service/pipes/enrichment_parameters_test.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55

66
"github.com/aws/aws-sdk-go-v2/service/pipes/types"
77
"github.com/aws/aws-sdk-go/aws"
8-
"github.com/stretchr/testify/assert"
8+
"github.com/google/go-cmp/cmp"
99
)
1010

1111
func Test_expandEnrichmentParameters(t *testing.T) {
@@ -68,7 +68,9 @@ func Test_expandEnrichmentParameters(t *testing.T) {
6868
t.Run(name, func(t *testing.T) {
6969
got := expandEnrichmentParameters([]interface{}{tt.config})
7070

71-
assert.Equal(t, tt.expected, got)
71+
if diff := cmp.Diff(got, tt.expected); diff != "" {
72+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
73+
}
7274
})
7375
}
7476
}
@@ -137,7 +139,9 @@ func Test_flattenEnrichmentParameters(t *testing.T) {
137139
t.Run(name, func(t *testing.T) {
138140
got := flattenEnrichmentParameters(tt.config)
139141

140-
assert.Equal(t, tt.expected, got)
142+
if diff := cmp.Diff(got, tt.expected); diff != "" {
143+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
144+
}
141145
})
142146
}
143147
}

internal/service/pipes/source_parameters_test.go

+10-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import (
66

77
"github.com/aws/aws-sdk-go-v2/service/pipes/types"
88
"github.com/aws/aws-sdk-go/aws"
9+
"github.com/google/go-cmp/cmp"
910
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
10-
"github.com/stretchr/testify/assert"
1111
)
1212

1313
func Test_expandSourceParameters(t *testing.T) {
@@ -544,7 +544,9 @@ func Test_expandSourceParameters(t *testing.T) {
544544
t.Run(name, func(t *testing.T) {
545545
got := expandSourceParameters([]interface{}{tt.config})
546546

547-
assert.Equal(t, tt.expected, got)
547+
if diff := cmp.Diff(got, tt.expected); diff != "" {
548+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
549+
}
548550
})
549551
}
550552
}
@@ -1023,7 +1025,9 @@ func Test_flattenSourceParameters(t *testing.T) {
10231025
t.Run(name, func(t *testing.T) {
10241026
got := flattenSourceParameters(tt.config)
10251027

1026-
assert.Equal(t, tt.expected, got)
1028+
if diff := cmp.Diff(got, tt.expected); diff != "" {
1029+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
1030+
}
10271031
})
10281032
}
10291033
}
@@ -1494,7 +1498,9 @@ func Test_expandSourceUpdateParameters(t *testing.T) {
14941498
t.Run(name, func(t *testing.T) {
14951499
got := expandSourceUpdateParameters([]interface{}{tt.config})
14961500

1497-
assert.Equal(t, tt.expected, got)
1501+
if diff := cmp.Diff(got, tt.expected); diff != "" {
1502+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
1503+
}
14981504
})
14991505
}
15001506
}

internal/service/pipes/target_parameters.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1693,7 +1693,7 @@ func flattenTargetBatchContainerOverrides(parameters *types.BatchContainerOverri
16931693
config := make(map[string]interface{})
16941694

16951695
if parameters.Command != nil {
1696-
config["command"] = flex.FlattenStringValueSet(parameters.Command)
1696+
config["command"] = flex.FlattenStringValueList(parameters.Command)
16971697
}
16981698
if parameters.InstanceType != nil {
16991699
config["instance_type"] = aws.ToString(parameters.InstanceType)
@@ -1891,7 +1891,7 @@ func flattenTargetECSTaskOverrideContainerOverride(parameters types.EcsContainer
18911891
config["name"] = aws.ToString(parameters.Name)
18921892
}
18931893
if parameters.Command != nil {
1894-
config["command"] = flex.FlattenStringValueSet(parameters.Command)
1894+
config["command"] = flex.FlattenStringValueList(parameters.Command)
18951895
}
18961896

18971897
var environmentValues []map[string]interface{}

internal/service/pipes/target_parameters_test.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import (
55

66
"github.com/aws/aws-sdk-go-v2/aws"
77
"github.com/aws/aws-sdk-go-v2/service/pipes/types"
8+
"github.com/google/go-cmp/cmp"
89
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
9-
"github.com/stretchr/testify/assert"
1010
)
1111

1212
func Test_expandTargetParameters(t *testing.T) {
@@ -542,7 +542,9 @@ func Test_expandTargetParameters(t *testing.T) {
542542
t.Run(name, func(t *testing.T) {
543543
got := expandTargetParameters([]interface{}{tt.config})
544544

545-
assert.Equal(t, tt.expected, got)
545+
if diff := cmp.Diff(got, tt.expected); diff != "" {
546+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
547+
}
546548
})
547549
}
548550
}
@@ -1104,7 +1106,9 @@ func Test_flattenTargetParameters(t *testing.T) {
11041106
t.Run(name, func(t *testing.T) {
11051107
got := flattenTargetParameters(tt.config)
11061108

1107-
assert.Equal(t, tt.expected, got)
1109+
if diff := cmp.Diff(got, tt.expected); diff != "" {
1110+
t.Errorf("unexpected diff (+wanted, -got): %s", diff)
1111+
}
11081112
})
11091113
}
11101114
}

0 commit comments

Comments
 (0)