Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mismatched max values betweenst sliders and number fields #4

Open
pdehaan opened this issue Oct 30, 2017 · 0 comments
Open

Some mismatched max values betweenst sliders and number fields #4

pdehaan opened this issue Oct 30, 2017 · 0 comments

Comments

@pdehaan
Copy link

pdehaan commented Oct 30, 2017

$ git grep -A1 "type='range'"
+ src/editor.js:          <input type='range' min='0' max='360' class='h' value=${color.h} tabIndex='-1'/>
+ src/editor.js-          <input type='number' value=${color.h} class='h-text' maxlength="3" max="360" min="0" />

- src/editor.js:          <input type='range' min='0' max='100' class='s' value=${color.s} tabIndex='-1'/>
- src/editor.js-          <input type='number' value=${color.s} class='s-text' maxlength="3" max="360" min="0" />

- src/editor.js:          <input type='range' min='0' max='100' class='l' value=${color.l} tabIndex='-1'/>
- src/editor.js-          <input type='number' value=${color.l} class='l-text' maxlength="3" max="360" min="0" />

+ src/editor.js:          <input type='range' min='0' max='100' class='a' value=${colors[index].a} tabIndex='-1'/>
+ src/editor.js-          <input type='number' value=${colors[index].a} class='a-text' maxlength="3" max="100" min="0" />

Looks like s and l sliders have a max=100 whereas their related number fields have a max=360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant