Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short scale instead of long scale for Polish locale #249

Closed
mjmikulski opened this issue Dec 16, 2021 · 2 comments
Closed

Short scale instead of long scale for Polish locale #249

mjmikulski opened this issue Dec 16, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mjmikulski
Copy link

mjmikulski commented Dec 16, 2021

What did you do?

Read the source code of Polish locale.

What did you expect to happen?

Have correct translation of 10**9 as "miliard".

What actually happened?

10**9 is translated as "bilion".

What versions are you using?

  • OS: NA
  • Python: NA
  • Humanize: master

Please include code that reproduces the issue.
NA

What is the correct solution?

French locale seems have it done right:

#: src/humanize/number.py:142
msgid "billion"
msgid_plural "billion"
msgstr[0] "milliard"
msgstr[1] "milliard"

In Polish we use long scale as in French.

Who can fix it?

I would be happy to fix it when I find some time ;)

Resources

Long scale vs short scale

@hugovk
Copy link
Collaborator

hugovk commented Dec 17, 2021

The Polish translations are in https://github.com/jmoiron/humanize/blob/master/src/humanize/locale/pl_PL/LC_MESSAGES/humanize.po

A PR would be welcome! You can edit the file directly via the GitHub UI, no need to create a local clone and push.

@hugovk hugovk added the bug Something isn't working label Dec 17, 2021
@hugovk
Copy link
Collaborator

hugovk commented May 3, 2022

🚀 Development has moved to https://github.com/python-humanize/humanize 🚀

Please open new issues at https://github.com/python-humanize/humanize/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants