Skip to content

Commit 0578393

Browse files
committed
Remove diag_send_complete from disable_averaging
diag_send_complete() is removed from disable_averaging(), due to potential performance costs over sweeping through files and variables for synchronization across nodes or other thread-like backround operations. It also prevents potential errors in drivers where diag_manager_set_time_end was unset. We will come back to this issue and work out a better strategy for diagnostic synchronization.
1 parent d66adff commit 0578393

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/framework/MOM_diag_mediator.F90

-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ module MOM_diag_mediator
1414
use MOM_diag_manager_infra, only : send_data_infra, MOM_diag_field_add_attribute, EAST, NORTH
1515
use MOM_diag_manager_infra, only : register_diag_field_infra, register_static_field_infra
1616
use MOM_diag_manager_infra, only : get_MOM_diag_field_id, DIAG_FIELD_NOT_FOUND
17-
use MOM_diag_manager_infra, only : diag_send_complete_infra
1817
use MOM_diag_remap, only : diag_remap_ctrl, diag_remap_update, diag_remap_calc_hmask
1918
use MOM_diag_remap, only : diag_remap_init, diag_remap_end, diag_remap_do_remap
2019
use MOM_diag_remap, only : vertically_reintegrate_diag_field, vertically_interpolate_diag_field
@@ -2079,10 +2078,8 @@ end subroutine enable_averages
20792078
subroutine disable_averaging(diag_cs)
20802079
type(diag_ctrl), intent(inout) :: diag_CS !< Structure used to regulate diagnostic output
20812080

2082-
call diag_send_complete_infra()
20832081
diag_cs%time_int = 0.0
20842082
diag_cs%ave_enabled = .false.
2085-
20862083
end subroutine disable_averaging
20872084

20882085
!> Call this subroutine to determine whether the averaging is

0 commit comments

Comments
 (0)