Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: this.getFilename is not a function, when trying to add shapes to custom libraries #274

Closed
2 tasks done
SanjayVyas opened this issue Apr 19, 2020 · 11 comments
Assignees

Comments

@SanjayVyas
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Trying to add a shape to custom library in draw.io desktop v12.9.13 results in an error "Uncaught TypeError: this.getFilename is not a function"

To Reproduce
Steps to reproduce the behavior:

  1. Open a new drawing (File>New)
  2. Create a new library (File > New Library..)
  3. Create a shape and select it
  4. Add to new library by clicking on "+"
  5. Save the library
  6. Save the file
  7. Exit draw.io desktop
  8. Run draw.io desktop
  9. Add another shape to drawing and select it
  10. Add to the custom library by clicking on "+"

Results in an error
Uncaught TypeError: this.getFilename is not a function

Expected behavior
Shapes should get added to custom library even after draw.io is restarted.

Screenshots
image

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 12.9.13 (edited from earlier typo)

Desktop (please complete the following information):

  • macOS Catalina 10.15.4
  • Using draw.io desktop

Smartphone (please complete the following information):

  • Not using smartphone

Additional context

  • This seems to happen only on desktop version and not web version
  • The standard "scratchpad" is unaffected, only custom lib, after saving once and reloading the desktop app start giving the error
@davidjgraph
Copy link
Contributor

Is it 12.9.13 or 12.9.14? When did you download this and where from?

@SanjayVyas
Copy link
Author

This is 12.9.13 and I downloaded it few days ago from GitHub release page. After I noticed the problem, I removed it completely (including settings and other data files on my Mac) and downloaded it again.. Still, same error.
image

image

@SanjayVyas
Copy link
Author

SanjayVyas commented Apr 20, 2020

oops.. just noticed I wrote 12.9.14 in my original post. Sorry, my bad.. its 12.9.13

@alderg alderg self-assigned this Apr 22, 2020
@alderg
Copy link
Contributor

alderg commented Apr 22, 2020

Thanks for the report. This will be fixed in the next release.

@alderg alderg closed this as completed Apr 22, 2020
@stevenilsen123
Copy link

I am getting the same problem on Windows version 13.0.1...

@davidjgraph davidjgraph reopened this Apr 28, 2020
@davidjgraph
Copy link
Contributor

@stevenilsen123 Following exactly the same steps as OP?

@geogdog
Copy link

geogdog commented Apr 29, 2020

I also have the exact same issue on 13.0.1/macOS 10.15.4. The same reproduce steps as the OP. draw.io is installed via homebrew.

@alderg
Copy link
Contributor

alderg commented Apr 29, 2020

This will be fixed in 13.0.2.

@davidjgraph davidjgraph transferred this issue from jgraph/drawio Apr 29, 2020
@davidjgraph
Copy link
Contributor

@SanjayVyas
Copy link
Author

Thank you so much... I can confirm that this has been fixed in 13.0.3 👍

@stevenilsen123
Copy link

Fixed for me too! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants