From 13b845df3e20d2c78447604b78a7ad633e67e911 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Thu, 26 Jan 2023 15:56:08 +0100 Subject: [PATCH] feat: upgrade to JSDOM@21 --- packages/jest-environment-jsdom/package.json | 2 +- packages/jest-environment-jsdom/src/index.ts | 7 ------- yarn.lock | 10 +++++----- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/packages/jest-environment-jsdom/package.json b/packages/jest-environment-jsdom/package.json index f1d1387c7493..1d8dd165fe31 100644 --- a/packages/jest-environment-jsdom/package.json +++ b/packages/jest-environment-jsdom/package.json @@ -24,7 +24,7 @@ "@types/node": "*", "jest-mock": "workspace:^", "jest-util": "workspace:^", - "jsdom": "^20.0.0" + "jsdom": "^21.1.0" }, "devDependencies": { "@jest/test-utils": "workspace:^" diff --git a/packages/jest-environment-jsdom/src/index.ts b/packages/jest-environment-jsdom/src/index.ts index f71f350becc8..f9d7c54c0135 100644 --- a/packages/jest-environment-jsdom/src/index.ts +++ b/packages/jest-environment-jsdom/src/index.ts @@ -160,13 +160,6 @@ export default class JSDOMEnvironment implements JestEnvironment { this.global.removeEventListener('error', this.errorEventListener); } this.global.close(); - - // Dispose "document" to prevent "load" event from triggering. - - // Note that this.global.close() will trigger the CustomElement::disconnectedCallback - // Do not reset the document before CustomElement disconnectedCallback function has finished running, - // document should be accessible within disconnectedCallback. - Object.defineProperty(this.global, 'document', {value: null}); } this.errorEventListener = null; // @ts-expect-error: this.global not allowed to be `null` diff --git a/yarn.lock b/yarn.lock index 6d9924191168..7b641fa143ba 100644 --- a/yarn.lock +++ b/yarn.lock @@ -12705,7 +12705,7 @@ __metadata: "@types/node": "*" jest-mock: "workspace:^" jest-util: "workspace:^" - jsdom: ^20.0.0 + jsdom: ^21.1.0 peerDependencies: canvas: ^2.5.0 peerDependenciesMeta: @@ -13414,9 +13414,9 @@ __metadata: languageName: node linkType: hard -"jsdom@npm:^20.0.0": - version: 20.0.3 - resolution: "jsdom@npm:20.0.3" +"jsdom@npm:^21.1.0": + version: 21.1.0 + resolution: "jsdom@npm:21.1.0" dependencies: abab: ^2.0.6 acorn: ^8.8.1 @@ -13449,7 +13449,7 @@ __metadata: peerDependenciesMeta: canvas: optional: true - checksum: 6e2ae21db397133a061b270c26d2dbc0b9051733ea3b896a7ece78d79f475ff0974f766a413c1198a79c793159119169f2335ddb23150348fbfdcfa6f3105536 + checksum: 2c89c72a6f399184ffc8de30bbdd86283086dbd72bb3a40667102d3f12af141c7517ffb78150a3bb6883a654e8c7d0266c3328d1c387a2b9a1fd0729dc537954 languageName: node linkType: hard