jenkinsci/jenkins-test-harness#921 should suffice

Author: jglick

pom.xml

@@ -70,6 +70,8 @@
     <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
     <jenkins.baseline>2.479</jenkins.baseline>
     <jenkins.version>${jenkins.baseline}.1</jenkins.version>
+    <!-- TODO https://github.com/jenkinsci/jenkins-test-harness/pull/921 -->
+    <jenkins-test-harness.version>2398.vd015803ca_4d3</jenkins-test-harness.version>
     <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
     <spotless.check.skip>false</spotless.check.skip>
   </properties>

src/test/java/com/cloudbees/jenkins/support/SupportTestUtils.java

@@ -20,10 +20,7 @@
 import java.io.ByteArrayOutputStream;
 import java.io.File;
 import java.io.IOException;
-import java.nio.file.DirectoryStream;
 import java.nio.file.Files;
-import java.nio.file.LinkOption;
-import java.nio.file.Path;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
@@ -347,30 +344,6 @@ public static void stopAgents() throws Exception {
             LOGGER.info("stopping " + agent);
             agent.toComputer().disconnect(null).get();
         }
-        var dir = Jenkins.get().getRootDir().toPath().resolve("agent-work-dirs");
-        for (int i = 0; i < 60; i++) {
-            try {
-                delete(dir);
-                LOGGER.info("successfully deleted " + dir);
-                return;
-            } catch (IOException x) {
-                LOGGER.log(Level.WARNING, "failed to delete " + dir + " on attempt #" + i, x);
-                Thread.sleep(1000);
-            }
-        }
-        LOGGER.warning("never managed to delete " + dir);
-    }
-
-    private static void delete(Path p) throws IOException {
-        LOGGER.info(() -> "deleting " + p);
-        if (Files.isDirectory(p, LinkOption.NOFOLLOW_LINKS)) {
-            try (DirectoryStream<Path> children = Files.newDirectoryStream(p)) {
-                for (Path child : children) {
-                    delete(child);
-                }
-            }
-        }
-        Files.deleteIfExists(p);
     }
 
     private SupportTestUtils() {}