Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foo a, ### comments ### {b: c} #1898

Closed
mozart0 opened this issue Nov 28, 2011 · 4 comments
Closed

foo a, ### comments ### {b: c} #1898

mozart0 opened this issue Nov 28, 2011 · 4 comments
Labels

Comments

@mozart0
Copy link

mozart0 commented Nov 28, 2011

foo a, ### comments ### {b: c}

PARSE ERROR ON LINE 1: UNEXPECTED 'CALL_END'

bug?

@TrevorBurnham
Copy link
Collaborator

It's not ideal, but it's not a bug. An intentional decision was made to require preserved comments to be outside of expressions, because it's a big parsing challenge and it's often unclear where /* comments */ should wind up in the compiled JS. This is why only ### comments are preserved, and those are intended mainly for things like copyright headers. See #41

@mozart0
Copy link
Author

mozart0 commented Nov 28, 2011

Thanks very much!

@satyr
Copy link
Collaborator

satyr commented Nov 28, 2011

Try: foo a, (### comments ###; b: c)

@GeoffreyBooth
Copy link
Collaborator

foo a, ### comments ### {b: c}

compiles now, via #4572. Sorry it took awhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants