Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier by default? #281

Closed
ericclemmons opened this issue May 25, 2017 · 6 comments
Closed

Prettier by default? #281

ericclemmons opened this issue May 25, 2017 · 6 comments

Comments

@ericclemmons
Copy link
Contributor

I know you loves some single quotes, but with Prettier gaining momentum, how do you feel about the code being prettier-formatted by default?

@jaredpalmer
Copy link
Owner

jaredpalmer commented May 25, 2017

Prettier already (with --write option) runs on Razzle before every commit using a precommit hook thanks to husky + lint-staged.

Config can be found here: https://github.com/jaredpalmer/razzle/blob/master/package.json#L26

@jaredpalmer
Copy link
Owner

jaredpalmer commented May 25, 2017

@ericclemmons would it be better if I commited my vscode workspace settings so people could just get formatOnSave?

@ericclemmons
Copy link
Contributor Author

Oooh! That must've been why I didn't see it happen. Hmmm, I dunno, because it only really affects new projects, so I'm not sure if that's much clutter or not.

@jaredpalmer
Copy link
Owner

Oh my bad. You meant adding Prettier to the templates, (I thought you meant to the repo). Yeah I can add it.

@stale
Copy link

stale bot commented Aug 15, 2018

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

@stale stale bot added the stale label Aug 15, 2018
@stale
Copy link

stale bot commented Aug 22, 2018

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

@stale stale bot closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants