Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Deprecated: Required parameter $post_id follows optional parameter $group #123

Closed
mwks-jg opened this issue Dec 6, 2022 · 1 comment
Closed

PHP Deprecated: Required parameter $post_id follows optional parameter $group #123

mwks-jg opened this issue Dec 6, 2022 · 1 comment

Comments

@mwks-jg
Copy link

mwks-jg commented Dec 6, 2022 •
edited
Loading

Plugin version

1.4.0

Current Behavior

Running the plugin locally with PHP 8.0.22 I see the below deprecated notice in WP debug log.

PHP Deprecated: Required parameter $post_id follows optional parameter $group in /wp-content/plugins/shared-counts/includes/class-shared-counts-admin.php on line 979
@cdils
Copy link

cdils commented Dec 7, 2022

Confirming I also see this in v.1.4.0 running PHP 8.0.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdils @mwks-jg