Skip to content

Commit f8d7a8d

Browse files
committed
Improve pre-commit hook keeping version in sync to handle beta versions
The git pre-commit hook we've been using the last years to keeping .version found in `package.json` in sync with the .version field exposed by the source code, did not handle version numbers often used for pre-relases like `beta | new` etc. Therefore making sure it searches for versions that also contains characters, not only numbers separated by dots. That will make sure the following is also seen as valid versions: `3.2.0-beta.0`, whereas before the `-beta` part would cause trouble.
1 parent 86fa37d commit f8d7a8d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

hooks/pre-commit

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class Bumper
7878
end
7979

8080
bumper = Bumper.new([
81-
Source.new('mustache.mjs', /version: '([\d\.]*)'/),
82-
Source.new('mustache.js.nuspec', /<version>([\d\.]*)<\/version>/),
81+
Source.new('mustache.mjs', /version: '([^']+)'/),
82+
Source.new('mustache.js.nuspec', /<version>([^<]+)<\/version>/),
8383
])
8484
bumper.start

0 commit comments

Comments
 (0)