bugfix: use of uninitialied variable

jankae · jankae · commit 7418e0807f28 · 2024-10-17T14:31:18.000+02:00
diff --git a/Software/LibreCAL-GUI/caldevice.cpp b/Software/LibreCAL-GUI/caldevice.cpp
@@ -243,7 +243,7 @@ void CalDevice::loadCoefficientSetsThreadSlow(QStringList names, QList<int> port
             totalPoints += usb->Query(":COEFF:NUM? "+name+" P"+QString::number(i)+"_SHORT").toInt();
             totalPoints += usb->Query(":COEFF:NUM? "+name+" P"+QString::number(i)+"_LOAD").toInt();
             for(int jdx=idx+1;jdx<numPorts;jdx++) {
-                int j = ports[j];
+                int j = ports[jdx];
                 totalPoints += usb->Query(":COEFF:NUM? "+name+" P"+QString::number(i)+QString::number(j)+"_THROUGH").toInt();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ void CalDevice::loadCoefficientSetsThreadSlow(QStringList names, QList<int> port`
`243`	`243`	`totalPoints += usb->Query(":COEFF:NUM? "+name+" P"+QString::number(i)+"_SHORT").toInt();`
`244`	`244`	`totalPoints += usb->Query(":COEFF:NUM? "+name+" P"+QString::number(i)+"_LOAD").toInt();`
`245`	`245`	`for(int jdx=idx+1;jdx<numPorts;jdx++) {`
`246`		`- int j = ports[j];`
	`246`	`+ int j = ports[jdx];`
`247`	`247`	`totalPoints += usb->Query(":COEFF:NUM? "+name+" P"+QString::number(i)+QString::number(j)+"_THROUGH").toInt();`
`248`	`248`	`}`
`249`	`249`	`}`