[fix] Refactor archive storage initialization and remove error log #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6636 +/- ##
==========================================
+ Coverage 95.93% 95.96% +0.02%
==========================================
Files 365 365
Lines 20609 20602 -7
==========================================
- Hits 19771 19770 -1
+ Misses 638 634 -4
+ Partials 200 198 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jan 30, 2025
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
Jan 31, 2025
| } | ||
|
|
||
| func (f *Factory) createArchiveSpanWriter() (spanstore.Writer, error) { | ||
| factory, ok := f.archiveFactories[f.SpanWriterTypes[0]] | ||
| func (f *Factory) InitArchiveStorage() (*ArchiveStorage, error) { |
There was a problem hiding this comment.
Why not just return 3 values?
There was a problem hiding this comment.
@yurishkuro I think its generally a pattern that is avoided in Go. I'm happy to change it if you like that better.
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
Jan 31, 2025
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Feb 11, 2025
…aegertracing#6636) ## Which problem is this PR solving? - Fixes jaegertracing#6634 ## Description of the changes - Remove the error logs for archive storage as it is not an error if archive storage cannot be configured - Remove the duplicate logs by only initializing the archive storage once for both query service and query service v2 ## How was this change tested? ``` make run-all-in-one {"level":"info","ts":1738292734.78397,"caller":"app/flags.go:168","msg":"Archive storage not initialized"} ``` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test