-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add esmapping-generator into jaeger binary #6327
Conversation
@yurishkuro I think now this is perfectly decoupling the logic for generation in tool and then calling it from jaeger binary. Looking forward to your suggestions! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6327 +/- ##
==========================================
- Coverage 96.23% 96.23% -0.01%
==========================================
Files 373 377 +4
Lines 21406 21421 +15
==========================================
+ Hits 20600 20614 +14
Misses 614 614
- Partials 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
24c7af6
to
01ad9bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is a user expected to run this?
01ad9bc
to
be85f38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, but some cleanup required
f2e79fb
to
5568b42
Compare
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
5568b42
to
1769154
Compare
"github.com/jaegertracing/jaeger/cmd/esmapping-generator/generator" | ||
) | ||
|
||
func Command(options app.Options) *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need options as argument? It seems it's always passed as zero value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not used in any way in tests. You set the params by passing CLI flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done !
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
Signed-off-by: Rohanraj123 <rajrohan88293@gmail.com>
Thanks! |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test