Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: asm.js type error in latest 1.61.0 version #5992

Open
GrzegorzDrozd opened this issue Sep 15, 2024 · 9 comments
Open

[Bug]: asm.js type error in latest 1.61.0 version #5992

GrzegorzDrozd opened this issue Sep 15, 2024 · 9 comments
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@GrzegorzDrozd
Copy link

GrzegorzDrozd commented Sep 15, 2024

What happened?

Entering trace compare page produces error in javascript console.
I am unable to pan, zoom or do anything in the graph.

Steps to reproduce

  1. enter trace comparison page.
  2. see error in the javascript console

Expected behavior

Do not see errors in js console.

Relevant log output

asm.js type error: expecting argument type declaration for 'A' of the form 'arg = arg|0' or 'arg = +arg' or 'arg = fround(arg)' at line 1, character: 1546428

Screenshot

Firefox, after pretty printing, highlights this line:
image

Additional context

No response

Jaeger backend version

1.61.0

SDK

Docker compose:

 inst-s-jaeger:
    image: jaegertracing/all-in-one:1.61.0
    environment:
      COLLECTOR_ZIPKIN_HOST_PORT: 9412
    ports:
      - "9412:9412"
      - "14317:4317"
      - "14318:4318"
      - "14268:14268"
      - "14250:14250"
      - "16686:16686"`

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

docker compose

Deployment configs

No response

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Sep 15, 2024
@yurishkuro
Copy link
Member

did it work in the previous version?

@GrzegorzDrozd
Copy link
Author

Hi @yurishkuro

I was unable to make 1.60 work. I could not make it accept traces from open telemetry collector :( it works like a charm with 1.61.0 (ingestion).

@madmecodes
Copy link

Hi @GrzegorzDrozd is this issue resolved, now?

@hostaway-greg
Copy link

Hi,

I finally got back to this. I see issue on 2.1.0 in both Firefox and on Chrome:
Image
Image
Attached is ams.js file from chrome. Please note that it looks like Chrome added new lines, and they might not match the error message…
asm.txt

@yurishkuro
Copy link
Member

Confirmed the issue w/ v2.1.0

@anshgoyalevil any ideas what could be causing this? The error seems all over Google, but I don't see a common root cause.

@anshgoyalevil
Copy link
Member

This is caused by viz.js as per development console.

Image

The viz.js version used by Plexus might be deprecated and using Node 12, which according to other repositories is harmless.

This error doesn't seem to be related to the zoom/pan not working on the TraceDiff page.

@yurishkuro
Copy link
Member

@anshgoyalevil thanks for the tips. We have an active PR to upgrade viz.js, so perhaps this error will go away. And for panning I will bring it up as part of the LFX project.

@GrzegorzDrozd
Copy link
Author

GrzegorzDrozd commented Jan 8, 2025

I assume that Pan and zoom on trace compare fix did not make it to 2.2.0 ?
Edit: I just checked with 2.2.0 and it did not :(

@yurishkuro
Copy link
Member

No , just missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

5 participants