Merge branch 'develop'

Author: charliewhitfield

CHANGELOG.md

@@ -6,9 +6,18 @@ File format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 See cloning and downloading instructions [here](https://www.ivoyager.dev/developers/).
 
+## [v0.0.20] - 2024-12-20
+
+Developed using Godot 4.3.
+
+### Changed
+* Updated custome godot.html shell using Godot 4.3's current master.
+* Updated plugin 'ivoyager_core' to v0.0.20.
+* Updated plugin 'ivoyager_table_importer' to v0.0.9.
+
 ## [v0.0.19] - 2024-12-16
 
-Developed Godot 4.3.
+Developed using Godot 4.3.
 
 ### Changed
 * Updated plugin 'ivoyager_core' to v0.0.19.
@@ -133,6 +142,7 @@ Requires non-Git-tracked **ivoyager_assets-0.0.10**; find in [ivoyager releases]
 * Updated submodule 'ivoyager' to v0.0.10.
 
 
+[v0.0.20]: https://github.com/ivoyager/planetarium/compare/v0.0.19...v0.0.20
 [v0.0.19]: https://github.com/ivoyager/planetarium/compare/v0.0.18...v0.0.19
 [v0.0.18]: https://github.com/ivoyager/planetarium/compare/v0.0.17...v0.0.18
 [v0.0.17]: https://github.com/ivoyager/planetarium/compare/v0.0.16...v0.0.17

addons/ivoyager_core

@@ -35,3 +35,8 @@ func _ready() -> void:
 	mod.init_min_size(IVEnums.GUISize.GUI_SMALL, Vector2(75.0, 0.0))
 	mod.init_min_size(IVEnums.GUISize.GUI_MEDIUM, Vector2(100.0, 0.0))
 	mod.init_min_size(IVEnums.GUISize.GUI_LARGE, Vector2(125.0, 0.0))
+	
+	prints('OS.has_feature("web")', OS.has_feature("web"))
+	
+	if OS.has_feature("web"):
+		%QuitButton.queue_free()

addons/ivoyager_table_importer

@@ -45,6 +45,7 @@ layout_mode = 2
 layout_mode = 2
 
 [node name="QuitButton" parent="VBox/MarginContainer1/MenuVBox" instance=ExtResource("5_caym3")]
+unique_name_in_owner = true
 layout_mode = 2
 force_quit = true
 

planetarium/gui/menu_panel.gd

@@ -105,10 +105,12 @@ func _on_project_nodes_added() -> void:
 func _on_simulator_started() -> void:
 	if OS.has_feature("web"):
 		# progressive web app (PWA) updating
-		if JavaScriptBridge.pwa_needs_update():
+		var pwa_needs_update := JavaScriptBridge.pwa_needs_update()
+		print("PWA nees update: ", pwa_needs_update)
+		if pwa_needs_update:
 			_on_pwa_update_available()
-		else:
-			JavaScriptBridge.pwa_update_available.connect(_on_pwa_update_available)
+			return
+		JavaScriptBridge.pwa_update_available.connect(_on_pwa_update_available)
 
 
 func _on_pwa_update_available() -> void:

planetarium/gui/menu_panel.tscn

@@ -40,11 +40,13 @@ extends Node
 #   METER = 1e-5 as above but less. Self-shadowing artifact?
 #   METER = 1e-7 lighting ok for all tested. (Harsh shadow border? Need to compare w/ below.)
 #   METER = 1e-10 lighting ok for all tested.
-
+#
+# Godot 4.3 update. Problems for HTML5 as above. However, Windows now appears
+# ok at 1e-10. Perhaps smaller value should be our base value (again)?
 
 # SI base units
 const SECOND := 1.0
-const METER := 1.0 # 1e-7 works for HTML5 export, as of Godot 4.2.beta4
+const METER := 1e-7 # see notes above
 const KG := 1.0
 const AMPERE := 1.0
 const KELVIN := 1.0

planetarium/preinitializer.gd

@@ -11,7 +11,7 @@ config_version=5
 [application]
 
 config/name="I, Voyager - Planetarium"
-config/version="v0.0.19"
+config/version="v0.0.20"
 run/main_scene="res://addons/ivoyager_core/tree_nodes/universe.tscn"
 config/features=PackedStringArray("4.3")
 boot_splash/bg_color=Color(0, 0, 0, 1)

planetarium/units.gd

@@ -1,5 +1,7 @@
 # Progressive Web App (PWA) Deployment
 
+Note: As of Godot 4.3, most PWA functionality seems to be broken. There is no caching or offline operation.
+
 Godot 3.4.1 introduced [PWA](https://web.dev/what-are-pwas/) functionality, but it's still a little rough to deploy as of Godot 4.2.1.
 
 These files are referenced in export_presets.config and used to generate the HTML5 export: