Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Potential decrease in runtime performance for release v.1.4.0 #1747

Closed
2 of 4 tasks
lukasfro opened this issue Jan 29, 2025 · 2 comments
Closed
2 of 4 tasks
Labels
bug Something isn't working

Comments

@lukasfro
Copy link

Describe the bug

I don't know whether you could call this a "bug" per se, but we noticed a decrease in runtime performance after upgrading to release v1.4.0. I'd be glad if someone else could confirm these results.

Steps to reproduce

I ran the benchmark_rlgames.py script with tags v1.3.0 and v1.4.0 checked out respectively:

  • --task=Isaac-Cartpole-RGB-Camera-Direct-v0 --num_envs=512 --enable_cameras --headless
  • --task=Isaac-Repose-Cube-Shadow-Direct-v0 --headless
  • --task=Isaac-Humanoid-v0 --headless

The following table summarizes some of the runtime KPIs that the benchmark provides:

For v1.3.0:

in millisecs Isaac-Cartpole-RGB-Camera-Direct-v0 Isaac-Repose-Cube-Shadow-Direct-v0 Isaac-Humanoid-v0
Min Env only step time 0.9988 0.9332 0.4514
Max Env only step time 1.0786 2.4190 1.4377
Mean Env only step time 1.0267 1.1632 0.5798

For v1.4.0:

in millisecs Isaac-Cartpole-RGB-Camera-Direct-v0 Isaac-Repose-Cube-Shadow-Direct-v0 Isaac-Humanoid-v0
Min Env only step time 1.0561 0.9742 0.7952
Max Env only step time 1.4216 2.5009 1.6507
Mean Env only step time 1.1108 1.2365 0.9133

Across all three tasks, the mean environment step time increases by up to 50% (Humanoid).

System Info

Describe the characteristic of your environment:

  • Commit: v1.3.0 and v1.4.0
  • Isaac Sim Version: pip list gives me isaacsim 4.2.0.2
  • OS: Ubuntu 22.04
  • GPU: RTX 4060 Ti
  • CUDA: 12.2
  • GPU Driver: 535.183.01

Additional context

I'm happy to help out with more comparisons.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have checked that the issue is not in running Isaac Sim itself and is related to the repo

Acceptance Criteria

Add the criteria for which this task is considered done. If not known at issue creation time, you can add this once the issue is assigned.

  • Criteria 1
  • Criteria 2
@Mayankm96
Copy link
Contributor

Yes, we are aware of this drop in the performance. The regression crept up in this MR: #966

We have made a fix since: #1695

@kellyguo11 @jtigue-bdai for vis

@lukasfro
Copy link
Author

Thanks for the quick reply @Mayankm96 I'm glad it is already fixed.

@RandomOakForest RandomOakForest added the bug Something isn't working label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants