This repository was archived by the owner on Aug 11, 2021. It is now read-only.
feat: revamped dag api #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
done, ready for review :) |
nicola
reviewed
Feb 8, 2017
|
|
||
| // pass an optional blockService, if no blockService is passed, | ||
| // one is created in memory. | ||
| const ipldResolver = new IPLDResolver(blockService) | ||
| const Resolver = new Resolver(blockService) |
There was a problem hiding this comment.
let's tell them that the blockService can be optional
| ``` | ||
|
|
||
| ## API | ||
|
|
||
| ### IPLD Resolver | ||
| ### `.put(node, <<cid> || <format>, <hashAlg>>, callback)` |
There was a problem hiding this comment.
Wasn't it meant to be {node: *, cid: *} (this is what I saw from the tests)
There was a problem hiding this comment.
see: https://github.com/ipfs/interface-ipfs-core/issues/81#issuecomment-277271941
tests were updated
There was a problem hiding this comment.
I saw it later on in the code while I was seeing this.
This makes much more sense and it is much cleaner, awesome!
(it just breaks my ipld selector tests! :D)
There was a problem hiding this comment.
I see, sorry about that, as you say it gets things clearer :)
| } | ||
|
|
||
| resolve (cid, path, callback) { | ||
| get (cid, path, options, callback) { |
kumavis
approved these changes
Feb 8, 2017
|
nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/ipfs/interface-ipfs-core/issues/81#issuecomment-277271941