Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Coverage (either Coveralls or Codecov) is not running in this repo. #40

Closed
daviddias opened this issue Sep 5, 2017 · 3 comments
Closed
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

#39 caused a big drop in coverage due to the addition of an auto generated file and it passed undetected because no Coverage CI is running.

=============================================================================
Writing coverage object [/Users/imp/code/js-ipld-dag-pb/coverage/coverage.json]
Writing coverage reports at [/Users/imp/code/js-ipld-dag-pb/coverage]
=============================================================================

=============================== Coverage summary ===============================
Statements   : 68.81% ( 311/452 )
Branches     : 39.6% ( 120/303 )
Functions    : 59.65% ( 34/57 )
Lines        : 68.6% ( 308/449 )
================================================================================
@daviddias
Copy link
Member Author

@dignifiedquire mind handling this as you go in your adventure of removing unsafe-eval from this world?

@dignifiedquire
Copy link
Member

That should be part of upgrading aegir, which makes this much more useful

@dignifiedquire
Copy link
Member

(also probably should find a way to ignore coverage for that module, not sure how though)

@daviddias daviddias added exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue status/ready Ready to be worked labels Oct 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants