Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Decode blocks correctly #21

Closed
vmx opened this issue Jun 27, 2018 · 1 comment
Closed

Decode blocks correctly #21

vmx opened this issue Jun 27, 2018 · 1 comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue

Comments

@vmx
Copy link
Member

vmx commented Jun 27, 2018

Currently if you pass in a Bitcoin block that includes transactions, it will only use the header part to calculate the CID. This is wrong.

The correct behaviour (to match the Go IPLD Bitcoin implementation is to distinguish between bitcoin-block (multicodec 0xb0), which is the header only and a bitcoin-tx (multicodec 0xb1).

So building the CID of a bitcoin-block would then be (as expected by IPLD) to hash the full data, which will then be correct as it only contains the header.
@vmx vmx added help wanted Seeking public contribution on this issue status/ready Ready to be worked exp/expert Having worked on the specific codebase is important labels Jun 27, 2018
@vmx vmx mentioned this issue Jun 27, 2018
Closed
@vmx
Copy link
Member Author

vmx commented Jul 17, 2018

I close this issue in favour of the much clearer one #25.

@vmx vmx closed this as completed Jul 17, 2018
@alanshaw alanshaw removed the status/ready Ready to be worked label Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmx @alanshaw