Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating the ClusterRoleBinding the namespace was set to the account name #5

Closed
nigelellis opened this issue Sep 24, 2020 · 1 comment

Comments

@nigelellis
Copy link
Contributor

When setting up the ClusterRoleBinding the namespace is being set incorrectly. Module is using the account name vs. account namespace:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  creationTimestamp: "2020-09-02T23:06:13Z"
  labels:
    app.kubernetes.io/managed-by: terraform
    app.kubernetes.io/name: aws-node-termination-handler
  name: aws-node-termination-handler
  resourceVersion: "184819743"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterrolebindings/aws-node-termination-handler
  uid: 5bb0258b-741f-4f41-a506-16fb7e837647
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: aws-node-termination-handler
subjects:
- kind: ServiceAccount
  name: aws-node-termination-handler
  namespace: aws-node-termination-handler      <<< *****

PR to address is at #4

Thanks.

@headcr4sh
Copy link
Collaborator

Closed by #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants