Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: landing & config page UX improvements #235

Merged
merged 10 commits into from
May 14, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Apr 29, 2024

Title

feat: landing & config page UX improvements

Description

Fixes #58

Summary of changes

  1. Add explainer with links to helper-ui (landing page)
  2. Allow setting dnsResolvers in config.
  3. Shows default urls in config
  4. Requires at least 1 dns resolver/router/gateway
  5. Adds "reset" button so users can get back to defaults if they bork things (TODO: need to fix this so it doesn't require a refresh, which will not work on first-hit for subdomain this todo is done.)

Landing page view

image

Config page view

image

Notes & open questions

FYI that inputs are still JSON based for now.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki linked an issue Apr 29, 2024 that may be closed by this pull request
@SgtPooki SgtPooki requested review from 2color, aschmahmann, lidel and a team April 29, 2024 19:21
@SgtPooki SgtPooki self-assigned this Apr 29, 2024
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review.. i'm going to try to provide a config-provider so we can call reset/save/etc there and remove the localStorage items

@lidel lidel force-pushed the 58-improve-ux-of-the-root-domain-landing-page branch 2 times, most recently from 7bea1db to f9187b2 Compare May 14, 2024 20:23
- moved About to the bottom and made it more friendly
- adjusted colors to improve contrast
- header to match other web utiities we have
@lidel lidel force-pushed the 58-improve-ux-of-the-root-domain-landing-page branch from f9187b2 to e24a80c Compare May 14, 2024 20:28
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Content lgtm, but it felt a bit distracting, so played a bit and ended up moving it to bottom.

Pushed a commit with some additional changes:

  • moved About to the bottom and made it more friendly for someone who wants to learn how things work
  • adjusted colors to improve contrast and indicate when button is enabled
  • tweaked the header to include (beta) and match style of other web utiities we have like https://explore.ipld.io/ or https://cid.ipfs.tech/

@SgtPooki @2color If these look good, feel free to merge or rephrase if anything sounds off.

Preview

Screen Shot 2024-05-14 at 22 13 49

@SgtPooki
Copy link
Member Author

@lidel that looks a lot cleaner. i'll fix up the CI and get this merged.

@SgtPooki SgtPooki merged commit fb9b04e into main May 14, 2024
16 checks passed
@SgtPooki SgtPooki deleted the 58-improve-ux-of-the-root-domain-landing-page branch May 14, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX of the root domain landing page
3 participants