Config inconsistent at runtime

[Stebalien]

Version information:

v0.5.1

Description:

The config attached to the command context is not the same config returned by repo.Config(). The commands context should just ask the repo for the config.

[schomatis]

@Stebalien Could you provide a code example, please?

[BigLep]

@Stebalien : do you have more input here so this can be actioned?

[Stebalien]

If we have an open repo stashed in the commands context, we should use the config from https://github.com/ipfs/go-ipfs/blob/d5ad847e05865e81957c43f526600860c06dbb84/repo/fsrepo/fsrepo.go#L500. (by calling repo.Config()).

I think the issue is that we could:

1. Call cctx.GetConfig(), which will cache it.
2. Modify the config somehow.
3. Call cctx.GetConfig(), getting the wrong config.

But I'm having trouble remembering why this is important. @aschmahmann can you remember why I filed this issue?

[BigLep]

2022-03-11 conversation: end goal is to make it crystal clear for users on whether they need to reboot or not when making config changes.

For priority determination, it would useful to know how many users are snagged by this issue.