From 3aed24ae82b25c3b5dcaf12e8aff26e3f1cdc6b7 Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Wed, 5 Mar 2025 21:04:24 +0100 Subject: [PATCH] test: fix flaky repo verify it seems verify not always notices file was broken, this fix performs explicit flush and assumes CI uses filesystem with lazy flush or some other unknown behavior --- test/sharness/t0086-repo-verify.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/sharness/t0086-repo-verify.sh b/test/sharness/t0086-repo-verify.sh index 0f12fef8f82..9d8ba2045fe 100755 --- a/test/sharness/t0086-repo-verify.sh +++ b/test/sharness/t0086-repo-verify.sh @@ -28,15 +28,17 @@ check_random_corruption() { test_expect_success "back up file and overwrite it" ' cp "$to_break" backup_file && - echo "this is super broken" > "$to_break" + echo "this is super broken" > "$to_break" && + sync "$to_break" ' test_expect_success "repo verify detects failure" ' test_expect_code 1 ipfs repo verify ' - test_expect_success "replace the object" ' - cp backup_file "$to_break" + test_expect_success "restore broken object" ' + cp backup_file "$to_break" && + sync "$to_break" ' test_expect_success "ipfs repo verify passes just fine now" '