Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove leftpad #22

Merged
merged 1 commit into from
May 23, 2019
Merged

fix: remove leftpad #22

merged 1 commit into from
May 23, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented May 23, 2019 •
edited
Loading

left-pad is deprecated in favor of String.prototype.padStart()

@hugomrdias hugomrdias requested a review from vasco-santos May 23, 2019 13:45
vasco-santos
vasco-santos approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I will include in the commit message a note regarding the deprecation of left-pad.

@hugomrdias
Copy link
Member Author

updated the OP so you should get the message when squashing

@vasco-santos vasco-santos merged commit e04babc into master May 23, 2019
@vasco-santos vasco-santos deleted the fix/remove-leftpad branch May 23, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @vasco-santos