fix: update record selection rules #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If a record has a v2 sig and the other does not, prefer that record - If the sequence numbers are equal, prefer the record with the longer validity - Otherwise prefer the first record
Make sure the embedded key, if present, matches the passed IPNS key as it should be derived from the embedded key. BREAKING CHANGE: extractPublicKey is now async
vasco-santos
approved these changes
Sep 1, 2021
| expect(entryDataCreated.ttl).to.equal(unmarshalledData.ttl) | ||
|
|
||
| if (!unmarshalledData.signatureV2) { | ||
| throw new Error('No v2 sig found') |
There was a problem hiding this comment.
nit: can we expect to have property instead?
There was a problem hiding this comment.
That would certainly be my preference! The problem here is that the type of .signatureV2 is Uint8Array | undefined and the type of arg in .equalBytes(arg) is ArrayLike<number> | string and the two are incompatible since arg cannot be undefined.
By checking if .signatureV2 has a truthy value tsc knows it's Uint8Array which is then compatible with ArrayLike<number>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform the same validation as go-ipns.
Also validates that embedded keys, where present, match the PeerId from the
IPNS Record.
Also, also: runs the type checker over the tests.
BREAKING CHANGE: extractPublicKey is now async