Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validator should create peer id #13

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

vasco-santos
Copy link
Member

Since libp2p-record does not have author (removed for interop with go-ipfs), validateRecord must find the peerId, using the key (/ipns/{peer_id})

BREAKING CHANGE: having the libp2p-record protobuf definition compliant with go-libp2p-record. Author and signature were removed.

@vasco-santos vasco-santos requested a review from fsdiogo November 15, 2018 17:56
@ghost ghost assigned vasco-santos Nov 15, 2018
@ghost ghost added the status/in-progress In progress label Nov 15, 2018
Copy link
Contributor

@fsdiogo fsdiogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BREAKING CHANGE: having the libp2p-record protobuf definition compliant with go-libp2p-record. Author and signature were removed.
@vasco-santos vasco-santos force-pushed the fix/validator-should-create-peer-id branch from cc925ef to 8fe8364 Compare November 15, 2018 18:02
@vasco-santos vasco-santos merged commit e1c1332 into master Nov 16, 2018
@ghost ghost removed the status/in-progress In progress label Nov 16, 2018
@vasco-santos vasco-santos deleted the fix/validator-should-create-peer-id branch November 16, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants