feat: store pins in datastore #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 12, 2020
Adds a `.pins` datastore to `ipfs-repo` and uses that to store
pins as cbor binary keyed by b58 stringified multihashes.
Each pin has several fields:
```javascript
{
cid: // buffer, the full CID pinned
type: // string, 'recursive' or 'direct'
name: // string, a human-readable name for the pin
}
```
BREAKING CHANGES:
* pins are now stored in a datastore, a repo miration will be necessary
* ipfs.pins.add now returns an async generator
* ipfs.pins.rm now returns an async generator
Depends on:
- [ ] ipfs/js-ipfs-repo#221
- [ ] ipfs-inactive/interface-js-ipfs-core#594
5 tasks
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 13, 2020
Adds a `.pins` datastore to `ipfs-repo` and uses that to store
pins as cbor binary keyed by b58 stringified multihashes.
Each pin has several fields:
```javascript
{
cid: // buffer, the full CID pinned
type: // string, 'recursive' or 'direct'
name: // string, a human-readable name for the pin
}
```
BREAKING CHANGES:
* pins are now stored in a datastore, a repo miration will be necessary
* ipfs.pins.add now returns an async generator
* ipfs.pins.rm now returns an async generator
Depends on:
- [ ] ipfs/js-ipfs-repo#221
- [ ] ipfs-inactive/interface-js-ipfs-core#594
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Mar 4, 2020
Adds a `.pins` datastore to `ipfs-repo` and uses that to store pins as cbor
binary keyed by base64 stringified multihashes (n.b. not CIDs).
Each pin has several fields:
```javascript
{
cid: // buffer, the full CID pinned
type: // string, 'recursive' or 'direct'
comments: // string, human-readable comments for the pin
}
```
BREAKING CHANGES:
* pins are now stored in a datastore, a repo migration will be necessary
* ipfs.pins.add now returns an async generator
* ipfs.pins.rm now returns an async generator
Depends on:
- [ ] ipfs/js-ipfs-repo#221
vasco-santos
approved these changes
Jul 21, 2020
test/pins-test.js
Outdated
| expect(repo).to.have.property('pins') | ||
| }) | ||
|
|
||
| it('implements interface-datastore', () => { |
There was a problem hiding this comment.
This test is redundant as datastore-level already runs the interface tests: https://github.com/ipfs/js-datastore-level/blob/master/test/index.spec.js#L44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
pinsdatastore to store pins in.