fix: more windows interop #147
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=========================================
Coverage ? 84.01%
=========================================
Files ? 9
Lines ? 269
Branches ? 0
=========================================
Hits ? 226
Misses ? 43
Partials ? 0Continue to review full report at Codecov.
|
package.json
Outdated
| "datastore-core": "~0.4.0", | ||
| "datastore-fs": "~0.4.0", | ||
| "datastore-level": "~0.6.0", | ||
| "datastore-level": "github:ipfs/js-datastore-level#windows-interop", |
There was a problem hiding this comment.
Change to use the actual version
There was a problem hiding this comment.
@diasdavid was not ready for a review yet. One the travis CI builds keeps on timing out.
| @@ -48,6 +48,7 @@ | |||
| "lodash": "^4.17.4", | |||
| "memdown": "^1.4.1", | |||
| "multihashes": "~0.4.12", | |||
| "multihashing-async": "^0.4.7", | |||
There was a problem hiding this comment.
yes, test/blockstore-test requires it. Its a devDependency
package.json
Outdated
| "test:browser": "aegir test --target browser", | ||
| "test": "aegir test --timeout 10000", | ||
| "test:node": "aegir test --target node --timeout 10000", | ||
| "test:browser": "aegir test --target browser --timeout 10000", |
There was a problem hiding this comment.
ok, will use .timeout on the bad test
|
Resolved the conflict with Master (package.json) |
|
@diasdavid seems that appveyor has placed us in queue; I've been waiting 30 mins. If it ever completes, could you review and release. I going off-line soon. |
No description provided.