Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/remove multiaddr #143

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Chore/remove multiaddr #143

merged 1 commit into from
Oct 13, 2017

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Sep 30, 2017

Removes outdated multiaddr dependency thats causing issues in ipfs - p2p-webrtc* addrs not being recognized

protocols-table.js:17 Uncaught Error: no protocol with name: p2p-webrtc-star
    at Protocols (protocols-table.js:17)
    at stringToStringTuples (codec.js:45)
    at stringToBuffer (codec.js:170)
    at Object.fromString (codec.js:178)
    at new Multiaddr (index.js:39)
    at Multiaddr (index.js:27)
    at WebRTCStar._peerDiscovered (index.js:223)
    at Socket.Emitter.emit (index.js:133)
    at Socket.onevent (socket.js:270)
    at Socket.onpacket (socket.js:228)

@dryajov dryajov force-pushed the chore/remove-multiaddr branch 2 times, most recently from cdd3f62 to 44c188b Compare September 30, 2017 07:57
@dryajov dryajov force-pushed the chore/remove-multiaddr branch from 44c188b to 71f276d Compare September 30, 2017 07:58
@daviddias daviddias merged commit 72b74ce into master Oct 13, 2017
@daviddias daviddias deleted the chore/remove-multiaddr branch October 13, 2017 16:34
@daviddias
Copy link
Member

@dryajov mind updating this repo to latest aegir as well? 🙏🏽

@dryajov
Copy link
Member Author

dryajov commented Oct 13, 2017

Sure thing, I'll update it! We might want to start an endeavor to get all our modules updated?

@daviddias
Copy link
Member

@dryajov go for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants