Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero length file does not show weight #2017

Closed
MarcelInTO opened this issue Aug 24, 2022 · 4 comments · Fixed by #2018
Closed

Zero length file does not show weight #2017

MarcelInTO opened this issue Aug 24, 2022 · 4 comments · Fixed by #2018
Labels
area/screen/files Issues related to Files screen kind/bug A bug in existing code (including security flaws) released

Comments

@MarcelInTO
Copy link

  • OS: Windows
  • Version of IPFS Desktop: 2.15.1

When browsing a folder of files (in the file section) where some files have been pinned and others have not, the pinned files do not show a size. The just show a "-".

Expected behavior
All files should show their size regardless of pin status.

Screenshots
image

@MarcelInTO MarcelInTO added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Aug 24, 2022
@hacdias
Copy link
Member

hacdias commented Sep 1, 2022

@MarcelInTO is that something that you can always reproduce? I cannot reproduce that issue. Maybe it's a temporary error fetching the details from a file? Can you check the Developer Tools (Ctrl+Shift+I, or F12) and see if there is any error in the Console tab?

@ipfs ipfs deleted a comment from welcome bot Sep 1, 2022
@hacdias hacdias added status/blocked Unable to be worked further until needs are met need/analysis Needs further analysis before proceeding need/author-input Needs input from the original author and removed need/triage Needs initial labeling and prioritization labels Sep 1, 2022
@MarcelInTO
Copy link
Author

MarcelInTO commented Sep 1, 2022

@hacdias Yes, it always happens. I have multiple machines on different networks with the same dataset pinned.

However, your comment about error fetching the details was on the right track and I had leapt to a conclusion before I submitted the issue

The dataset is about 200000' files that had been pinned recursively. I just scanned through it and it appears that the files that show this issue are actually all zero length.

So I would rewrite the issue report and repro steps this way:

  • Create a folder of files where some files are zero length
  • Recursively lock the folder
  • Explore the contents of the folder on the Files page.
  • Note that the files that were zero length show a pin symbol but no size
  • Note that the files that were not zero length do not show a pin symbol and show a size

Expected behavior;

  • Zero length files should show a length just like other files (zero is a valid file size)
  • The display of the pin symbol for recursively pinned content should be consisten and not depend on whether the file is zero length or not

@hacdias hacdias transferred this issue from ipfs/ipfs-desktop Sep 2, 2022
@ipfs ipfs deleted a comment from welcome bot Sep 2, 2022
@hacdias
Copy link
Member

hacdias commented Sep 2, 2022

After taking a look, this issue is not related to pinned files. The issue here is that a zero length file shows - instead of 0 B on the size column.

To reproduce:

  1. touch blank_file
  2. ipfs add blank_file -> CID will be QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH
  3. ipfs cp /ipfs/QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH /blank_file
  4. See on IPFS Web UI

@hacdias hacdias changed the title Files display does not show size for pinned files Zero length file does not show weight Sep 2, 2022
@hacdias hacdias added area/screen/files Issues related to Files screen and removed status/blocked Unable to be worked further until needs are met need/analysis Needs further analysis before proceeding need/author-input Needs input from the original author labels Sep 2, 2022
Repository owner moved this from To do to Done in IPFS-GUI (PL EngRes) Sep 12, 2022
@ipfs-gui-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen kind/bug A bug in existing code (including security flaws) released
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants