Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote pins: remove automatic status check #1902

Closed
lidel opened this issue Feb 8, 2022 · 1 comment
Closed

remote pins: remove automatic status check #1902

lidel opened this issue Feb 8, 2022 · 1 comment
Labels
area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Feb 8, 2022

Task extracted from #1900

Given rate-limiting described in #1900 we are unable to check pin status of every file.
Even if we introduce back-off, having 6 requests / minute (current Pinata limit) means users won't be able to check status for files when visiting more than 6 folders in one minute.

Proposal

  • Remove automatic remote pin check when browsing Files.
  • Check for remote pin status only when user opens Set pinning screen
  • Store remote pins in local storage, and re-check them when ipfs-webui loads for the first time (removing them only if check confirmed the item is no longer remotely pinned)

This should significantly reduce the number of requests sent to pinning services, and have minimal impact on IPFS Desktop users (assumption being they would only do pinning via GUI
@lidel lidel added exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up effort/hours Estimated to take one or several hours area/pinning Integrating pinning into GUI apps labels Feb 8, 2022
@lidel
Copy link
Member Author

lidel commented Feb 11, 2022

Closed by #1903

@lidel lidel closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel