Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build.sh assumes globally installed browserify #37

Closed
dignifiedquire opened this issue Sep 1, 2015 · 4 comments
Closed

Build.sh assumes globally installed browserify #37

dignifiedquire opened this issue Sep 1, 2015 · 4 comments
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
v0.1.0

Comments

@dignifiedquire
Copy link
Member

Not mentioned in the readme, and let's the npm run start script hang. Should probably just use a local one
@harlantwood
Copy link
Contributor

This should probably be fixed by changing browserify in build.sh to node_modules/.bin/browserify.

@dignifiedquire
Copy link
Member Author

agreed

@harlantwood harlantwood mentioned this issue Sep 1, 2015
Merged
@harlantwood
Copy link
Contributor

PR: #38.

@daviddias
Copy link
Member

Thank you for catching and fixing that :)

@daviddias daviddias added this to the v0.1.0 milestone Sep 1, 2015
@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Sep 1, 2015
@snyk-bot snyk-bot mentioned this issue Jul 10, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 18, 2022
Open
@0racl3z 0racl3z mentioned this issue Jul 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
3 participants
@harlantwood @dignifiedquire @daviddias