Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towards peer-* compatibility #634

Open
pgte opened this issue Dec 7, 2018 · 1 comment
Open

towards peer-* compatibility #634

pgte opened this issue Dec 7, 2018 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog

Comments

@pgte
Copy link

pgte commented Dec 7, 2018

(I'm opening this up for discussion, so that, if you're interested and it's feasible, the DDC working group can plan our contributions to this.)

For these reasons, it would be great that peer-star could use Companion for all things IPFS and libp2p.

From recent conversations and a quick analysis, I think Companion would have to be able to provide peer-star with:

  • Ability to use a custom transport and discovery (defined in a JS module)
  • Ability to implement a custom libp2p protocol (defined in a JS module)
  • Ability to use pub-sub (including event-driven interface for notification of remote subscription changes)
@lidel
Copy link
Member

lidel commented Dec 7, 2018

Sounds feasible as long embedded js-ipfs is used.
Pubsub use with go-ipfs is blocked by ipfs-inactive/js-ipfs-http-client#518 and I am unsure how custom transports/protocols could be added when HTTP API is used (probably needs changes to go-ipfs itself?).

If you switch to experimental Embedded js-ipfs backend, then you will be able to specify JSON with custom configuration for that node (enable pubsub, set custom signaling servers and transport modules).

@pgte based on what I know at the moment, next steps are:

  • Identify and document what are the extras you need.
    • Make a list of all customization peer-* need on top of default js-ipfs config and post in this issue.
  • Add custom JS modules to Companion so they are available for embedded js-ipfs when custom config refers to them.
    • Ideally peer-* team would do the PR, but I can help the details or make time if more of involvement is needed.
    • The path forward would be for peer-* team to create a PR each time an update is needed.
  • (needs evaluation) if safe, perhaps change default config that ships with companion to enable these changes out of the box.

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog labels Dec 7, 2018
@galargh galargh moved this to To do in IPFS-GUI (PL EngRes) Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants