Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduplicate content-type-parser.ts #191

Closed
lidel opened this issue Feb 28, 2025 · 2 comments · Fixed by #193
Closed

deduplicate content-type-parser.ts #191

lidel opened this issue Feb 28, 2025 · 2 comments · Fixed by #193
Assignees
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Feb 28, 2025

We seem to have the same code related to content type parsersing in multiple places:

There should be a single source of truth, having unique copy used only in conformance tests reduces trust in having meaningful content-type tests anywhere

@lidel lidel added the P1 High: Likely tackled by core team if no one steps up label Feb 28, 2025
@SgtPooki SgtPooki self-assigned this Mar 4, 2025
@SgtPooki SgtPooki transferred this issue from ipfs/service-worker-gateway Mar 4, 2025
@SgtPooki
Copy link
Member

SgtPooki commented Mar 6, 2025

action items:

  1. determine bundle size once adding into verified-fetch by default before proceeding.. we don't want to increase size dramatically
  2. switch back to original file-type library since Consider alternate (browser friendly) buffer sindresorhus/file-type#578 is closed now

@SgtPooki
Copy link
Member

SgtPooki commented Mar 6, 2025

size increase of verified-fetch is < 25kb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants