Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

docs: fs already defined in example #1

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jun 8, 2023

Fixes non-compileable code example where we set both node:fs import and unixfs(helia) to a variable fs.

Fixes non-compileable code example where we set both `node:fs` import and `unixfs(helia)` to a variable `fs`.
Copy link

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import order, node:fs > node:stream, lgtm

@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 3, 2023

ping @achingbrain, I don't have permissions to assign review to you nor merge this.

@achingbrain achingbrain changed the title fix: fs already defined in example docs: fs already defined in example Jul 3, 2023
@achingbrain
Copy link
Member

I've added @ipfs/helia-dev to this repo - you should have perms now 👍

@achingbrain
Copy link
Member

Nb. I changed the PR title from fix: to docs: because otherwise it'll appear in the bugfix section of the release notes.

@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 3, 2023

@SgtPooki SgtPooki merged commit 356797a into ipfs:main Jul 3, 2023
@SgtPooki SgtPooki deleted the patch-1 branch July 3, 2023 21:09
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
## [@helia/car-v1.0.1](https://github.com/ipfs/helia-car/compare/@helia/car-v1.0.0...@helia/car-v1.0.1) (2023-08-14)

### Documentation

* fs already defined in example ([#1](#1)) ([356797a](356797a))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants