Skeleton for tests

Author: magik6k

api.go

@@ -35,7 +35,11 @@ func NewLocalApi() iface.CoreAPI {
 		baseDir = DefaultPathRoot
 	}
 
-	baseDir, err := homedir.Expand(baseDir)
+	return NewPathApi(baseDir)
+}
+
+func NewPathApi(p string) iface.CoreAPI {
+	baseDir, err := homedir.Expand(p)
 	if err != nil {
 		return nil
 	}
@@ -51,21 +55,31 @@ func NewLocalApi() iface.CoreAPI {
 		return nil
 	}
 
-	return NewApi(strings.TrimSpace(string(api)))
+	maddr, err := ma.NewMultiaddr(strings.TrimSpace(string(api)))
+	if err != nil {
+		return nil
+	}
+
+	return NewApi(maddr)
 }
 
-func NewApi(url string) *HttpApi {
+func NewApi(a ma.Multiaddr) *HttpApi { // TODO: should be MAddr?
 	c := &gohttp.Client{
 		Transport: &gohttp.Transport{
 			Proxy:             gohttp.ProxyFromEnvironment,
 			DisableKeepAlives: true,
 		},
 	}
 
-	return NewApiWithClient(url, c)
+	return NewApiWithClient(a, c)
 }
 
-func NewApiWithClient(url string, c *gohttp.Client) *HttpApi {
+func NewApiWithClient(a ma.Multiaddr, c *gohttp.Client) *HttpApi {
+	_, url, err := manet.DialArgs(a)
+	if err != nil {
+		return nil // TODO: return that error
+	}
+
 	if a, err := ma.NewMultiaddr(url); err == nil {
 		_, host, err := manet.DialArgs(a)
 		if err == nil {

api_test.go

@@ -0,0 +1,84 @@
+package httpapi
+
+import (
+	"context"
+	"fmt"
+	"github.com/ipfs/iptb/testbed/interfaces"
+	"io/ioutil"
+	"os"
+	"path"
+	"strconv"
+	"testing"
+
+	"github.com/ipfs/go-ipfs/core/coreapi/interface"
+	"github.com/ipfs/go-ipfs/core/coreapi/interface/tests"
+
+	local "github.com/ipfs/iptb-plugins/local"
+	"github.com/ipfs/iptb/cli"
+	"github.com/ipfs/iptb/testbed"
+)
+
+type NodeProvider struct{}
+
+func (NodeProvider) MakeAPISwarm(ctx context.Context, fullIdentity bool, n int) ([]iface.CoreAPI, error) {
+	_, err := testbed.RegisterPlugin(testbed.IptbPlugin{
+		From:        "<builtin>",
+		NewNode:     local.NewNode,
+		GetAttrList: local.GetAttrList,
+		GetAttrDesc: local.GetAttrDesc,
+		PluginName:  local.PluginName,
+		BuiltIn:     true,
+	}, false)
+	if err != nil {
+		return nil, err
+	}
+
+	dir, err := ioutil.TempDir("", "httpapi-tb-")
+	if err != nil {
+		return nil, err
+	}
+
+	c := cli.NewCli()
+	if err := c.Run([]string{"iptb", "--IPTB_ROOT", dir, "auto", "-type", "localipfs", "-count", strconv.FormatInt(int64(n), 10), "--start"}); err != nil {
+		return nil, err
+	}
+
+	go func() {
+		<-ctx.Done()
+
+		defer os.Remove(dir)
+
+		defer func() {
+			_ = c.Run([]string{"iptb", "--IPTB_ROOT", dir, "stop"})
+		}()
+	}()
+
+	apis := make([]iface.CoreAPI, n)
+
+	for i := range apis {
+		tb := testbed.NewTestbed(path.Join(dir, "testbeds", "default"))
+
+		node, err := tb.Node(i)
+		if err != nil {
+			return nil, err
+		}
+
+		attrNode, ok := node.(testbedi.Attribute)
+		if !ok {
+			return nil, fmt.Errorf("node does not implement attributes")
+		}
+
+		pth, err := attrNode.Attr("path")
+		if err != nil {
+			return nil, err
+		}
+
+		apis[i] = NewPathApi(pth)
+	}
+
+	return apis, nil
+}
+
+func TestHttpApi(t *testing.T) {
+	tests.TestApi(&NodeProvider{})(t)
+}