Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested objects in Datagrid #1

Open
datanotion opened this issue Apr 23, 2015 · 2 comments
Open

Nested objects in Datagrid #1

datanotion opened this issue Apr 23, 2015 · 2 comments

Comments

@datanotion
Copy link

Hello Pascal! Once again, thanks for taking over/branching this project. It's a shame Telerik refuses to dedicate even a single paid employee to maintain it.

Anyway, I'm having an issue trying to get the Kendo Grid to work with Breeze data when it contains nested objects.

Basically once the JSON goes through the _makeResults method, it doesn't have any of the nested navigation properties anymore. They look correct in the data.results property while in that method, but it looks like they are skipped on purpose.

So I'm guessing this was done to deal with the inability of Kendo's datagrid to handle self referencing objects or something?

Populating a simple array of nested objects works fine of course so I know it's possible, but before we start modifying breeze-kendo to include those fields, can you explain why its setup that way? Or is it just a bug? Or in the works?

Thank you!

@pascalberger
Copy link
Contributor

Unfortunately I don't use neither the Grid nor have nested objects.

There's a commit in a PR on the original project of @Rdefreitas that looks like it does fix some aspects of this (even though only for the first level): rondefreitas/breeze-kendo@3879b5f (which is the only commit I haven't merged, since I'm not using it myself and not sure how polished it is).

If you are willing to work on an implementation on this I'm more than willing to accept a PR, but since I'm not using it myself I unfortunately don't have the time to implement it myself.

@datanotion
Copy link
Author

I merged and have tweaked a few things. I'll let it run live for a few weeks and see if there are any problems, then I'll submit a pull request if it runs smooth. I might tweak some more and do at least 2 levels as well. Thanks Pascal!

JarbasHorst added a commit that referenced this issue Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants