New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete consensus data from tables when it is no longer needed (#19697) · MystenLabs/sui@fedfb0d #4678

Closed

bingyanglin opened this issue Jan 6, 2025 · 1 comment · Fixed by #5053

Assignees

Labels

good first issue node

Contributor

bingyanglin commented Jan 6, 2025

Delete consensus data from tables when it is no longer needed (#19697) · MystenLabs/sui@fedfb0d

refactory to remove consensus data from tables when it is no longer needed.

bingyanglin added node good first issue labels

gokhan-simsek-iota self-assigned this

Contributor

gokhan-simsek-iota commented Jan 21, 2025 •

edited

Loading

In short: Not applicable without investigating/changing to newer code.

Details:
These upstream changes require these and related newer version objects and more dependent code changes:

assigned_shared_object_versions_v2
pending_checkpoints_v2

So this one does not seem to be a simple task, and does not seem that we cannot apply these changes without investigating/changing to newer code.

Next Actions:

Investigate and apply required upstream changes and then this change.
Or do not merge this and close this issue

This was referenced Jan 22, 2025

Check relevant changes since upstream mainnet-v1.32.2 and produce a report with possible upstream patches that are of interest (features, bug fixes) #3990

Closed

fix(node): Merge from upstream - Delete consensus data from tables when it is no longer needed #5053

Merged

gokhan-simsek-iota closed this as completed in #5053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment