Return error from Start function (#13)

Returning an error from `Start` function will allow us to report the
error and exit with a proper exit code.

Author: alissonbrunosa

cmd/git-pair/main.go

@@ -11,7 +11,7 @@ import (
 )
 
 func main() {
-	cli.VersionPrinter = func(cCtx *cli.Context) {
+	cli.VersionPrinter = func(*cli.Context) {
 		printVersion()
 	}
 
@@ -31,8 +31,7 @@ func main() {
 				Aliases: []string{"s"},
 				Usage:   "Start pairing mode",
 				Action: func(*cli.Context) error {
-					Start()
-					return nil
+					return Start()
 				},
 			},
 			{

cmd/git-pair/start.go

@@ -9,47 +9,43 @@ import (
 	"github.com/inverse/git-pair/internal/util"
 )
 
-func Start() {
+func Start() error {
 	localContributors, err := contributors.GetLocalContributors()
 	if err != nil {
-		fmt.Printf("Failed to load local contributors: %s\n", err)
-		return
+		return fmt.Errorf("Failed to load local contributors: %w", err)
 	}
 
 	repoContributors, err := git.GetRepoContributors()
 	if err != nil {
-		fmt.Printf("Failed to load repo contributors: %s\n", err)
-		return
+		return fmt.Errorf("Failed to load repo contributors: %w", err)
 	}
 
 	allContributors := util.UniqueStrings(append(localContributors, repoContributors...))
 	if len(allContributors) == 0 {
-		fmt.Println("No contributors found")
-		return
+		fmt.Println("⚠️ No contributors found")
+		return nil
 	}
 
-	selectedContributors := []string{}
+	var selectedContributors []string
+
 	prompt := &survey.MultiSelect{
 		Message: "Who's pairing:",
 		Options: allContributors,
 	}
 
-	err = survey.AskOne(prompt, &selectedContributors)
-	if err != nil {
-		fmt.Println(err)
-		return
+	if err := survey.AskOne(prompt, &selectedContributors); err != nil {
+		return err
 	}
 
 	if len(selectedContributors) == 0 {
 		fmt.Println("You must select at least one contributor")
-		return
+		return nil
 	}
 
-	err = git.EnablePairingMode(selectedContributors)
-	if err != nil {
-		fmt.Println(err)
-		return
+	if err := git.EnablePairingMode(selectedContributors); err != nil {
+		return err
 	}
 
 	fmt.Println("🚀 Pairing mode started")
+	return nil
 }