-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression error on ROS buildfarm #63
Comments
Trying locally (Indigo on Virtual machine): $ git clone -b indigo-devel https://github.com/introlab/rtabmap.git
$ cd rtabmap
$ bloom-generate rosdebian --os-name ubuntu --os-version trusty --ros-distro indigo
$ fakeroot debian/rules binary and there is no error at the end (though some warnings):
The 0.10 libraries are correctly built in rtabmap/debian/ros-indigo-rtabmap/opt/ros/indigo/lib $ ls
librtabmap_core.so librtabmap_gui.so librtabmap_utilite.so rtabmap-0.10
librtabmap_core.so.0.10 librtabmap_gui.so.0.10 librtabmap_utilite.so.0.10
librtabmap_core.so.0.10.10 librtabmap_gui.so.0.10.10 librtabmap_utilite.so.0.10.10 Not sure why on the ROS buildfarm they are not found? |
Could it be because of This line (from: http://build.ros.org/view/Ibin_uT64/job/Ibin_uT64__rtabmap__ubuntu_trusty_amd64__binary/6/consoleFull):
Points to You could also change the above line to include the folder you would expect https://github.com/introlab/rtabmap-release/blob/debian/indigo/trusty/rtabmap/debian/rules#L55 |
Thank you, yes GNUInstallDirs is used. It seems effectively the problem looking at the install section of the log. For example:
The libraries are installed in |
Ok, just make sure you try it out after the deb builds because I'm not sure whether or not our setup file will add Another option would be to disable GNUInstallDirs when building in our farm (by way of CMake variable passed in the rules files for example). |
The last successful build of the same version (February 1): I'll look to disable GNUInstallDirs for the buildfarm. |
I missed that GNUInstallDirs is already disabled for catkin (similar to your suggestion on this post): # Catkin doesn't support multiarch library path,
# fix to "lib" if not set by user.
IF(NOT DEFINED CMAKE_INSTALL_LIBDIR)
set(CMAKE_INSTALL_LIBDIR "lib")
ENDIF(NOT DEFINED CMAKE_INSTALL_LIBDIR)
INCLUDE(GNUInstallDirs) I tested on my side and |
Hmm, not sure why that would be. @dirk-thomas @tfoote |
Or maybe it is related to cmake version (I used 2.8.12.2) and now CMake overrides EDIT |
I see a successful build of rtabmap. What did you change? http://build.ros.org/job/Ibin_uT32__rtabmap__ubuntu_trusty_i386__binary/8/ rtabmap_ros looks like a linking error with the new release of rviz. @wjwwood fyi http://build.ros.org/job/Ibin_uT32__rtabmap_ros__ubuntu_trusty_i386__binary/11/console |
Looks like they have an implicit dependency on rviz's default plugin, same issue here: moveit/moveit_ros#654 |
|
It seems to be building on x86 but still has a problem on armhf linking: http://build.ros.org/view/Ibin_arm_uThf/job/Ibin_arm_uThf__rtabmap__ubuntu_trusty_armhf__binary/9/console |
Oh I missed that one, I was looking on http://repositories.ros.org/status_page/ros_indigo_default.html. I added |
Great it looks to have rebuilt successfully on armhf too. There's a parallel build statue page for the arm builds. http://repositories.ros.org/status_page/ros_indigo_arm.html |
Everything is green (or blue), I guess I can close this issue. Thx for the help! |
The error happens when packaging the .deb:
References:
The text was updated successfully, but these errors were encountered: