Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dropdown Menu to Facet Carousels #10512

Open
6 tasks
mekarpeles opened this issue Feb 26, 2025 · 2 comments
Open
6 tasks

Add Dropdown Menu to Facet Carousels #10512

mekarpeles opened this issue Feb 26, 2025 · 2 comments
Labels
Fellowship Opportunity Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Carousels Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Proposal

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Feb 26, 2025

Feature Request

Problem / Opportunity

Today, our subject pages are not useful to most [international] audiences because they either see random works or likely books predominantly in English.

Once we merge:

We will be able to change either all the carousels on a page or a single carousel by having some sort of facet or dropdown option.

My preference is that (for starters) each carousel would have its own filter icon
Image

Which would allow the patron to (a) specify language, (b) add tags to the query, (c) toggle ebook only

Proposal

For v1, success means the ability to click a filter or cog icon and apply additional filters or facets (similar to the search page) to a carousel. A requirement is that language be a dropdown and that "All" is selected by default. Presumably this should be sticky across page loads but/and have an easy way to x and clear facets.

Github does something similar, which is having a cog that allows patrons to specify tags or other facets, e.g.

Image
Image

Breakdown

Related files

Refer to this map of common Endpoints:
*

Requirements Checklist

Checklist of requirements that need to be satisfied in order for this issue to be closed:

  • Clicking facets should somehow replace or update the existing carousel (or items), possibly using a partial?
  • A loading indicator should appear after facets are added, while the carousel is reloading.
  • Clicking on x clear all the facets and reloads the original carousel
  • An update button should be clicked in order to save the state
  • Show somehow if/when facets are sticky set on a specific carousel (e.g. cog or filter is a different color, or we show a bar with the facets selected (that you can x / clear like the search page).
  • Use localstorage to save a mapping of carousel_id to "query" and "settings": {} where the settings contains the options in the UI and the query is what gets sent to solr.

Stakeholders

  • @jimchamp has implemented our carousel partials

Instructions for Contributors

@mekarpeles mekarpeles added Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Carousels Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Proposal labels Feb 26, 2025
@mekarpeles mekarpeles added this to the Sprint 2025-03 milestone Feb 26, 2025
@mekarpeles mekarpeles changed the title Create Facet Cog for Filtering Carousels Add Dropdown Menu to Facet Carousels Feb 26, 2025
@mekarpeles mekarpeles added the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Feb 28, 2025
@Alok-2005
Copy link

Hi @mekarpeles ,

I would like to take on this issue and contribute to implementing the carousel filtering functionality. I have reviewed the requirements and breakdown, and I am confident in handling the necessary updates, including UI enhancements, facet management, and local storage integration.

Could you kindly assign this issue to me? Additionally, if there are any specific guidelines, existing implementations, or best practices I should follow, please let me know.

Looking forward to your guidance and contributing to this improvement.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Mar 6, 2025
@mekarpeles
Copy link
Member Author

@Alok-2005 as a first step, can you provide a basic low-fidelity design / mock-up / proposal based on the requirements above, including which files you believe may need to be updated?

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fellowship Opportunity Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Carousels Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Proposal
Projects
None yet
Development

No branches or pull requests

2 participants