Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_branch_protection still slow with version 4.0.0 #606

Closed
SanderKnape opened this issue Nov 13, 2020 · 9 comments
Closed

github_branch_protection still slow with version 4.0.0 #606

SanderKnape opened this issue Nov 13, 2020 · 9 comments
Labels
r/branch_protection Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented

Comments

@SanderKnape
Copy link

As was reported earlier with version 3.1.0, the performance of the github_branch_protection resource has slowed down significantly now that this resource is using v4 of the GitHub API. It makes using the github provider unusable when working with dozens of repositories.

Is there a way to keep using the v3 version of the API somehow?

@jcudit
Copy link
Contributor

jcudit commented Nov 17, 2020

There was some discussion around a new resource pinned at the v3 / REST implementation over here. Still unclear on what an acceptable migration path would be though if we went ahead with this approach. Any ideas?

🤔 there is also the optimization approach in case anyone can recommend ways to improve the GraphQL implementation.

@SanderKnape
Copy link
Author

Hmm, I understand the problem. I'm not sure what the best approach would be. Adding the github_branch_protection_v3 resource sounds like a reasonable option. As long as I can use future versions of this provider with the branch protection performance of API v3, I don't have a strong preference for a specific implementation. I can't comment on which implementation would be the easiest to maintain moving forward.

@lijok
Copy link

lijok commented Jul 5, 2021

Reason for its slowness: #849

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 7, 2022
@akloss-cibo
Copy link

Oof... this is still super annoying. Like really. A lot.

@kfcampbell
Copy link
Member

github_branch_protection_v3 still uses the REST API, which may help. I'd be very receptive to thoughts on how to improve the experience using the GraphQL API.

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Sep 5, 2023
@akloss-cibo
Copy link

It's still slow. We pretty heavily use/abuse -target to avoid planning around github things because of how much longer it takes to run the plans.

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Sep 6, 2023
Copy link

github-actions bot commented Jun 2, 2024

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jun 2, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r/branch_protection Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

5 participants