Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v0.31.1 #1298

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Prepare release v0.31.1 #1298

merged 3 commits into from
Apr 17, 2023

Conversation

erwanor
Copy link
Collaborator

@erwanor erwanor commented Apr 16, 2023

Prepare v0.31.1 to expose TypedEvent as intented in #1288.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@erwanor erwanor marked this pull request as ready for review April 16, 2023 22:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Merging #1298 (67c88cc) into main (ffbf990) will decrease coverage by 0.1%.
The diff coverage is n/a.

❗ Current head 67c88cc differs from pull request most recent head 5a6c58c. Consider uploading reports for the commit 5a6c58c to get more accurate results

@@           Coverage Diff           @@
##            main   #1298     +/-   ##
=======================================
- Coverage   64.2%   64.2%   -0.1%     
=======================================
  Files        271     271             
  Lines      24450   24450             
=======================================
- Hits       15720   15719      -1     
- Misses      8730    8731      +1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hdevalence
Copy link
Collaborator

I realized I didn't commit the .changelog entries from 0.31.0, so I rebased and folded them into that commit, and updated the docs in 5a6c58c

@hdevalence hdevalence merged commit adf235f into main Apr 17, 2023
@hdevalence hdevalence deleted the release/v0.31.1 branch April 17, 2023 04:58

### FEATURES

- Expose the `tendermint::abci::event::TypedEvent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- - Expose the `tendermint::abci::event::TypedEvent
+ - Expose the `tendermint::abci::event::TypedEvent`

@@ -0,0 +1 @@
Expose the `TypedEvent` marker trait.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually have dates associated with releases.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the other summary.mds and they don't seem to have a date attached to it, what am i missing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time a date was applied was v0.29.0

@@ -0,0 +1 @@
* `[tendermint, tendermint-p2p]` Bump `ed25519` to v2, `k256` to v0.13, and `signature` to v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to PR/issue?

@@ -0,0 +1 @@
Upgrade signature crate versions and add a `TypedEvent` trait for ABCI events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing a release date here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants