You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should do the same for abci::EventAttribute too. We may need to break this issue into sub-issues for each set of events for: client, connection, channel, packet, host, handler, routing.
Feature Summary
Currently, we have
impl From<T> for TmAbciEvent
for an event typeT
. But the other way around is not implemented.Proposal
Implement
impl TryFrom<TmAbciEvent> for T
for all event typeT
. For example, theCreateClient
case:https://github.com/cosmos/ibc-rs/blob/4ea4dcb863efa12f5628a05588e2207112035e4a/ibc-core/ics02-client/types/src/events.rs#L210-L221
The following
TryFrom
implementation is missing:We should do the same for
abci::EventAttribute
too. We may need to break this issue into sub-issues for each set of events for: client, connection, channel, packet, host, handler, routing.Requested by @penso
The text was updated successfully, but these errors were encountered: